Skip to content

feat(TopicData): add topic message details in Drawer #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 16, 2025
Merged

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented May 8, 2025

closes #1942
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: 🔺

Current: 83.57 MB | Main: 83.53 MB
Diff: +0.05 MB (0.06%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug changed the title Ydb topic message feat(TopicData): add topic message details in Drawer May 8, 2025
@Raubzeug Raubzeug force-pushed the ydb-topic-message branch from 5f78be4 to c0c06b2 Compare May 13, 2025 12:05
@Raubzeug Raubzeug force-pushed the ydb-topic-message branch from c0c06b2 to 5c4489f Compare May 14, 2025 15:36
@Raubzeug
Copy link
Contributor Author

@astandrik @artemmufazalov all changes were done, design review passed, stand redeployed!

@Raubzeug Raubzeug requested a review from artemmufazalov May 16, 2025 13:47
@artemmufazalov
Copy link
Member

Hovered selected rows have additional margins around copy buttons

Screenshot 2025-05-16 at 16 52 46

@Raubzeug
Copy link
Contributor Author

Hovered selected rows have additional margins around copy buttons

Screenshot 2025-05-16 at 16 52 46

I saw this, but for now I don't have a good decision. Suggest to think about it in separate issue: #2297 (comment)

@Raubzeug Raubzeug added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 025d5ff May 16, 2025
7 checks passed
@Raubzeug Raubzeug deleted the ydb-topic-message branch May 16, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants